Faster checks for non-observable types

salesforce · Dec 17, 2018 · 826cbd8 · 826cbd8
1 parent 7d515ee
commit 826cbd8
Showing 1 changed file with 16 additions and 5 deletions.
diff --git a/src/reactive-membrane.ts b/src/reactive-membrane.ts
@@ -53,12 +53,23 @@ function defaultValueIsObservable(value: any): boolean {
     if (value == null) {
         return false;
     }
-    if (isArray(value)) {
-        return true;
-    }
 
-    const proto = getPrototypeOf(value);
-    return (proto === ObjectDotPrototype || proto === null || getPrototypeOf(proto) === null);
+    switch (typeof value) {
+        // Quicker decisions for non-observable types. All possible values of typeof https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/typeof#Description
+        case 'boolean':
+        case 'number':
+        case 'string':
+        case 'symbol':
+        case 'function':
+            return false;
+        default:
+            if (isArray(value)) {
+                return true;
+            }
+
+            const proto = getPrototypeOf(value);
+            return (proto === ObjectDotPrototype || proto === null || getPrototypeOf(proto) === null);
+    }
 }
 
 const defaultValueObserved: ReactiveMembraneAccessCallback = (obj: any, key: PropertyKey) => {