io provider aws ec2 resource, getStatus() checking SSM visibility #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realstraw
reviewed
May 27, 2022
| logger.debug(s"getStatus: result = $res") | ||
| res | ||
| } catch { | ||
| case e: Throwable => Left(e) |
There was a problem hiding this comment.
what potential exceptions are we expecting here?
There was a problem hiding this comment.
when testing locally just on the Ec2Resource, I created from command line an ec2 instance, and passed in a wrong instanceId (due to typo), and got an Ec2Exception from ec2client.describeInstances() call
software.amazon.awssdk.services.ec2.model.Ec2Exception: Invalid id: "i-04efef9282d2ee064kkk" (Service: Ec2, Status Code: 400, Request ID: 69df7559-351e-43e5-9abc-b8eea71fb742)
Normally though, the Ec2Resource class would not be called with getStatus having a wrong instanceId value. I think even the terminated instances would be around for a while with status = terminated.
realstraw
approved these changes
May 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to io provider aws ec2 resource, getStatus() checking SSM visibility
In the time gap when an Ec2 instance is created, and SSM service is not aware of the new instance yet, if an activity attempt is executed on the ec2 instance, the following error would occur without this change.
[error] 2022-05-27 14:49:15,686 c.s.m.o.s.a.ActivityAttempt$ - ActivityAttempt Actor[akka://application/user/orchard-system/wf-2ddb477a-52bc-419b-8b8b-86749e7df124/act-activityId_2/attempt-1#-1267839591] exception in creating task
software.amazon.awssdk.services.ssm.model.InvalidInstanceIdException: Instances [[i-04a8d2699077682b1]] not in a valid state for account 802707170857 (Service: Ssm, Status Code: 400, Request ID: 695a92b3-e94f-490b-9b19-b7b14b6bb7a5)