Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filenames containing special characters renamed to HTML encoded variant #74

Open
ppavacic opened this issue Jan 12, 2024 · 4 comments
Open

Comments

@ppavacic
Copy link
Contributor

ppavacic commented Jan 12, 2024

For example, file named helloworld#1.jpg in perforce is renamed to helloworld%231.jpg in git.
File named helloworld%1.png in perforce is renamed to helloworld%251.png.
# = %23
% = %25

I assume that somewhere where files is being requested you simply use end of url as file name

@twarit-waikar
Copy link
Contributor

I assume that somewhere where files is being requested you simply use end of url as file name

We do take the file name that we get back as is, but apparently there is some HTML encoding taking place which shouldn't actually be there.

@ppavacic
Copy link
Contributor Author

I can patch it, got any pointers where to look?

@twarit-waikar
Copy link
Contributor

@ppavacic Thank you for looking! Probably could start here by seeing how BranchedFileGroups is handling file paths, because that's what in the end goes to the GitAPI like so

@ppavacic
Copy link
Contributor Author

ppavacic commented Jan 19, 2024

@twarit-waikar not sure which url-decode library should I add? Do you have any suggestions?
perhaps this one: https://github.com/cpp-netlib/url, fork of: https://github.com/cpp-netlib/uri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants