Ensured minimization won't break if resource path contains special characters and improve the unit tests for minimization #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aracters; improve the unit tests for minimization
saikirankv
pushed a commit
to saikirankv/policy_sentry
that referenced
this pull request
Nov 18, 2020
…aracters and improve the unit tests for minimization (salesforce#259) * Ensured minimization won't break if resource path contains special characters; improve the unit tests for minimization * Added more test cases for the minimizing functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#252 introduced a bug where the Sid would be invalid if the resource path had any special characters in it. This PR ensures that does not happen.
What gif best describes this PR or how it makes you feel?
Completion checklist