Added click unit tests #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikirankv
pushed a commit
to saikirankv/policy_sentry
that referenced
this pull request
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I just added some Click unit tests because (1) It was fun to learn that, (2) I am maintainer and I say so (lol jk but only kinda), and (3) someone asked for click unit tests for their upcoming change so I thought I'd give a demo of how it would work here.
I also changed a value in the examples/yml/crud-cases/3-wildcard-only-single-actions.yml file because secretsmanager:CreateSecret supports resource ARN constraints now.
What gif best describes this PR or how it makes you feel?
Completion checklist