Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #266 SID contains dash #267

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Conversation

Alegrowin
Copy link
Contributor

Generated policy for anything containing a dash in actions based generate SID with a dash

mode: actions
name: 'RoleNameWithActions'
actions:

  • access-analyzer:CreateAnalyzer

What does this PR do?

Fix a bug when using action based policy containing a dash

What gif best describes this PR or how it makes you feel?

image

Completion checklist

@salesforce-cla
Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): aproulx <a***@m***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @Alegrowin to sign the Salesforce.com Contributor License Agreement.

@kmcquade
Copy link
Collaborator

Thanks!

@kmcquade kmcquade merged commit 0166584 into salesforce:master Oct 21, 2020
saikirankv pushed a commit to saikirankv/policy_sentry that referenced this pull request Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants