Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onDiscard hook support to AbstractStreamObserverAndPublisher #292

Closed
bruto1 opened this issue Feb 13, 2022 · 0 comments
Closed

Add onDiscard hook support to AbstractStreamObserverAndPublisher #292

bruto1 opened this issue Feb 13, 2022 · 0 comments
Labels
enhancement

Comments

@bruto1
Copy link
Contributor

bruto1 commented Feb 13, 2022

Currently, upon cancellation it just clears the queue, but its elements, for example, can be backed by reference counted objects which need to be released before being garbage collected (it's possible thanks to GoogleCloudPlatform/grpc-gcp-java#77 )
An example of when and how discarding is done can be found in FluxFlatMap, for example, or any other operator impl with a queue
bruto1 pushed a commit to bruto1/reactive-grpc that referenced this issue Feb 14, 2022
fixes salesforce#292 (supposedly)
851f581
bruto1 added a commit to bruto1/reactive-grpc that referenced this issue Feb 14, 2022
@bruto1
fixes salesforce#292 (supposedly)
77dabe8
bruto1 added a commit to bruto1/reactive-grpc that referenced this issue Feb 14, 2022
@bruto1
fixes salesforce#292 (supposedly)
25eb33d
@rmichela rmichela mentioned this issue Mar 24, 2022
Open
rmichela added a commit that referenced this issue Apr 11, 2023
@rmichela
Merge pull request #293 from bruto1/bug/discard-issue-292
5f3e1be 
issue #292 - discard support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rmichela @bruto1