Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host_javabase is deprecated #294

Open
juanpmarin opened this issue Feb 23, 2022 · 1 comment
Open

host_javabase is deprecated #294

juanpmarin opened this issue Feb 23, 2022 · 1 comment
Labels

Comments

@juanpmarin
Copy link

juanpmarin commented Feb 23, 2022

Since bazel 5.0 the parameter used here is deprecated:

host_javabase = find_java_runtime_toolchain(ctx, ctx.attr._host_javabase),

Generating the following error:

Traceback (most recent call last):
	File "/home/juan/.cache/bazel/_bazel_juan/7e6e30ecb52b472e0900bbc0b820a797/external/com_salesforce_servicelibs_reactive_grpc/bazel/java_reactive_grpc_library.bzl", line 71, column 36, in _reactive_grpc_library_impl
		java_info = java_common.compile(
Error in compile: in call to compile(), parameter 'host_javabase' is deprecated and will be removed soon. It may be temporarily re-enabled by setting --incompatible_java_common_parameters=false

The documentation suggests that it can be just dropped:
image

Do you find any risk on doing this?

@rmichela
Copy link
Collaborator

I'm not sure. I'm not really a Bazel expert. If you drop this, does everything Bazel still work?

@rmichela rmichela added the bazel label Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants