Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backpressure #58

Closed
bsideup opened this issue Feb 26, 2018 · 7 comments
Closed

Backpressure #58

bsideup opened this issue Feb 26, 2018 · 7 comments
Labels

Comments

@bsideup
Copy link
Contributor

bsideup commented Feb 26, 2018

Hi!

Are there any well-known backpressure issues? I get backpressure-related exceptions in my app (based on Reactor) and I have a feeling that they come from reactive-grpc.

I know that there is no "request demand" notion in gRPC and you have to deal with readiness, this is why I expect issues with backpressure by nature.

@rmichela
Copy link
Collaborator

Can you be more specific about the backpressure-related exceptions you are getting?

@cbornet Perhaps you can help?

@bsideup
Copy link
Contributor Author

bsideup commented Feb 26, 2018

@rmichela Reactor gives me OverflowException

Don't get me wrong, I'm still not sure whom to blame, just wanted to re-check, maybe there are some known issues with backpressure in reactive-grpc

@rmichela
Copy link
Collaborator

I'm not going to say there isn't an issue in reactive-grpc. 😁 It passes the TCK, but the gRPC and Reactive backpressure models are subtly different and there may still be an impedance mismatch in the code.

What's the stack trace of your OverflowException?

@bsideup
Copy link
Contributor Author

bsideup commented Feb 28, 2018

@rmichela I'm running different tests right now to figure out where the problem is.

Too many moving parts (my code, gRPC, reactive-gRPC, gRPC-netty/Armeria, client, client's code), I'll try to narrow it first :)

@rmichela
Copy link
Collaborator

Thanks! Keep me posted.

Even if the problem isn't in RxGrpc itself, your findings will make for good documentation. 😉

@rmichela
Copy link
Collaborator

rmichela commented Mar 8, 2018

@bsideup Any update?

@bsideup
Copy link
Contributor Author

bsideup commented Mar 12, 2018

Hi @rmichela,

So far so good :) We had an issue with Armeria, but when we reverted it to gRPC-netty + reactive-grpc everything became stable 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants