Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition #126

Merged
merged 1 commit into from Oct 23, 2018
Merged

Fix race condition #126

merged 1 commit into from Oct 23, 2018

Conversation

rmichela
Copy link
Collaborator

Fixes #123

@rmichela
Copy link
Collaborator Author

@bsideup Please take a look

@codecov-io
Copy link

Codecov Report

Merging #126 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #126      +/-   ##
============================================
- Coverage     36.37%   36.29%   -0.09%     
  Complexity       54       54              
============================================
  Files            27       27              
  Lines           635      631       -4     
  Branches         26       26              
============================================
- Hits            231      229       -2     
+ Misses          392      390       -2     
  Partials         12       12
Impacted Files Coverage Δ Complexity Δ
...pc/common/ReactiveStreamObserverPublisherBase.java 64.58% <ø> (-1.42%) 6 <0> (ø)
.../common/ReactiveStreamObserverPublisherClient.java 70.58% <ø> (+3.92%) 6 <0> (ø) ⬇️
.../common/ReactiveStreamObserverPublisherServer.java 40% <ø> (+1.29%) 6 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daa1184...f70a681. Read the comment docs.

@rmichela rmichela merged commit 5789b3b into master Oct 23, 2018
@rmichela rmichela deleted the bugfix/null-race branch October 23, 2018 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants