New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/jmh+improvements #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can combine the two JMH modules into a single module with one runner. You can generate RxJava and Reactor stubs in the same POM and run both harnesses side by side. This will cut out a bunch of code duplication.
...mon/src/main/java/com/salesforce/reactivegrpc/common/AbstractStreamObserverAndPublisher.java
Outdated
Show resolved
Hide resolved
...mon/src/main/java/com/salesforce/reactivegrpc/common/AbstractStreamObserverAndPublisher.java
Show resolved
Hide resolved
...or-grpc-jmh/src/test/java/com/salesforce/reactorgrpc/jmh/BenchmarkGRpcServerServiceImpl.java
Outdated
Show resolved
Hide resolved
...grpc-jmh/src/test/java/com/salesforce/reactorgrpc/jmh/BenchmarkReactorServerServiceImpl.java
Outdated
Show resolved
Hide resolved
Can you please put bullet points in the PR description for the fixes you made and the dependency upgrades you made? |
Failed tests:
|
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
============================================
+ Coverage 47.2% 48.17% +0.96%
+ Complexity 116 115 -1
============================================
Files 28 28
Lines 841 822 -19
Branches 81 81
============================================
- Hits 397 396 -1
+ Misses 420 401 -19
- Partials 24 25 +1
Continue to review full report at Codecov.
|
@rmichela fixed all comments |
This PR provides the following:
AbstractStreamObserverAndPublisher
by specifying the lowerTild for next prefetch (it means that we don't have to wait for full prefetch fulfillment so upstream have some space to send, and downstream does not call request to frequently)