Skip to content

Commit

Permalink
Merge 6f28746 into 8bc959a
Browse files Browse the repository at this point in the history
  • Loading branch information
jgraff2 committed Mar 16, 2019
2 parents 8bc959a + 6f28746 commit 2795b50
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
7 changes: 6 additions & 1 deletion src/remoteCollection/handleCollectResponse.js
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,12 @@ function generateSamples(collectRes) {
*/
const func = RefocusCollectorEval.getTransformFunction(tr, status);
if (func) {
return RefocusCollectorEval.safeTransform(func, args);
try {
return RefocusCollectorEval.safeTransform(func, args);
} catch (err) {
const errorMessage = `Transform error: ${err.message} (${collectRes.preparedUrl})`;
return errorSamples(collectRes, errorMessage);
}
}

// Default error samples
Expand Down
5 changes: 0 additions & 5 deletions src/utils/httpUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -138,11 +138,6 @@ function doBulkUpsert(url, userToken, intervalSecs, proxy, arr) {
return Promise.resolve(e);
}

// Don't bother sending a POST if the array is empty.
if (arr.length === 0) {
return Promise.resolve(true);
}

url += bulkUpsertEndpoint;
return new Promise((resolve) => {
debug('Bulk upserting %d samples to %s', arr.length, url);
Expand Down

0 comments on commit 2795b50

Please sign in to comment.