Resolve unauthorized error every hour #184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamigo
approved these changes
May 9, 2019
|
@pallavi2209 tests? |
iamigo
suggested changes
May 9, 2019
| */ | ||
|
|
||
| const startTime = new Date().getTime(); | ||
| const tokenWaitInterval = 100 || Number(process.env.TOKEN_WAIT_INTERVAL); |
There was a problem hiding this comment.
it will never look up the value from process.env because 100 is always truthy
i think you meant
Number(process.env.TOKEN_WAIT_INTERVAL) || 100;
|
Let me try and add some tests. |
|
I think this is getting too complicated for a short-term fix. If this level of complexity is required to make it work, we should just address the root cause now. I created a story for that yesterday. |
|
@jgraff2 thx for your feedback on this now that we have a manageable immediate-term change in place, I'm all for doing it right |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
One generator results in 401 error and sets token to null to retrieve fresh token
By the time the first generator gets the token, other generators also result in 401 error, and create error samples (they assume they have right token and it is some legit 401 error)
Now:
Few generator clones assume they have right token (until first gen sets the token to null) -> results in 401 -> go and get new token -> try again
Once the first gen sets teh token to null -> Other generators can recognize that there is some generator on its way to get the token and they wait for first generator to get the token.