Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(format): make the error messages more readable #13

Merged
merged 48 commits into from
Jun 2, 2020
Merged

refactor(format): make the error messages more readable #13

merged 48 commits into from
Jun 2, 2020

Commits on May 14, 2020

  1. chore: update deps

    Mohan Raj Rajamanickam committed May 14, 2020
    Configuration menu
    Copy the full SHA
    3cf9f86 View commit details
    Browse the repository at this point in the history

  2. chore: fix eslint config for changes in 7.0 

    https://eslint.org/docs/user-guide/migrating-to-7.0.0#default-ignore-patterns
    Mohan Raj Rajamanickam committed May 14, 2020
    Configuration menu
    Copy the full SHA
    8c69649 View commit details
    Browse the repository at this point in the history

  3. ci: rename test lint phase to build 

    to make the badge in readme follow common convention
    Mohan Raj Rajamanickam committed May 14, 2020
    Configuration menu
    Copy the full SHA
    255fd76 View commit details
    Browse the repository at this point in the history

  4. test(format): reuse test data, setup from test utils

    Mohan Raj Rajamanickam committed May 14, 2020
    Configuration menu
    Copy the full SHA
    2b755d6 View commit details
    Browse the repository at this point in the history

  5. build: remove global-jsdom dep and registration steps 

    as it doesn't seem to be affecting the tests??
    Mohan Raj Rajamanickam committed May 14, 2020
    Configuration menu
    Copy the full SHA
    e3c869e View commit details
    Browse the repository at this point in the history

Commits on May 27, 2020

  1. build: replace ts-cleaner with rimraf to clean dist files 

    as rimraf is generic and reusable
    Mohan Raj Rajamanickam committed May 27, 2020
    Configuration menu
    Copy the full SHA
    61573aa View commit details
    Browse the repository at this point in the history

Commits on May 28, 2020

  1. refactor(test-utils): move check a11y error from assert to test-utils 

    add corresponding tests
    Mohan Raj Rajamanickam committed May 28, 2020
    Configuration menu
    Copy the full SHA
    6f81850 View commit details
    Browse the repository at this point in the history

  2. build: remove jsdom, add jest matcher utils to format deps 

    jsdom as direct dependency doesn't seem to be needed anymore
    Mohan Raj Rajamanickam committed May 28, 2020
    Configuration menu
    Copy the full SHA
    2b1fb4b View commit details
    Browse the repository at this point in the history

  3. refactor(common): add common package

    Mohan Raj Rajamanickam committed May 28, 2020
    Configuration menu
    Copy the full SHA
    2028f91 View commit details
    Browse the repository at this point in the history

  4. refactor(common): reuse const from common in assert, test-utils

    Mohan Raj Rajamanickam committed May 28, 2020
    Configuration menu
    Copy the full SHA
    fb2aafa View commit details
    Browse the repository at this point in the history

Commits on May 29, 2020

  1. test: change toBeDefined matcher to toBeTruthy as null is defined! 

    expect(null).toBeDefined();                      // success
    Mohan Raj Rajamanickam committed May 29, 2020
    Configuration menu
    Copy the full SHA
    90babaf View commit details
    Browse the repository at this point in the history

  2. feat(format): add num of issues, unicode chars, jest matcher helper 

    Reformat a11y error msg to include total num of issues, unicode chars to represent a11y issue & help
url, rearrange error msg fields, add jest matcher helper to include more info about received vs
actual
    Mohan Raj Rajamanickam committed May 29, 2020
    Configuration menu
    Copy the full SHA
    757020a View commit details
    Browse the repository at this point in the history

  3. build: update dependencies, npm scripts

    Mohan Raj Rajamanickam committed May 29, 2020
    Configuration menu
    Copy the full SHA
    2c92e5d View commit details
    Browse the repository at this point in the history

  4. chore(release): update changelog

    Mohan Raj Rajamanickam committed May 29, 2020
    Configuration menu
    Copy the full SHA
    b21570d View commit details
    Browse the repository at this point in the history

  5. chore(release): bump versions

    Mohan Raj Rajamanickam committed May 29, 2020
    Configuration menu
    Copy the full SHA
    5726a98 View commit details
    Browse the repository at this point in the history

  6. docs(rules): update readme to include rule descriptions (#12) 

    docs(rules): add readme information with details about the rules included in each pre-config ruleset
    @cordeliadillon
    cordeliadillon authored and Mohan Raj Rajamanickam committed May 29, 2020
    Configuration menu
    Copy the full SHA
    3fd7e55 View commit details
    Browse the repository at this point in the history

  7. build: add lint check to pre-push git hook

    Mohan Raj Rajamanickam committed May 29, 2020
    Configuration menu
    Copy the full SHA
    303dfe5 View commit details
    Browse the repository at this point in the history

  8. revert: revert update of deps due to eslint issues after upgrade

    Mohan Raj Rajamanickam committed May 29, 2020
    Configuration menu
    Copy the full SHA
    838387d View commit details
    Browse the repository at this point in the history

  9. build: rename npm scripts for consistency

    Mohan Raj Rajamanickam committed May 29, 2020
    Configuration menu
    Copy the full SHA
    20c19ba View commit details
    Browse the repository at this point in the history

  10. build: add ci option to test ci npm script

    Mohan Raj Rajamanickam committed May 29, 2020
    Configuration menu
    Copy the full SHA
    0076a7c View commit details
    Browse the repository at this point in the history

  11. build(ci): workaround jest snapshot errors in github CI 

    #14

Workaround for #14
    Mohan Raj Rajamanickam committed May 29, 2020
    Configuration menu
    Copy the full SHA
    6e73cd6 View commit details
    Browse the repository at this point in the history

  12. Revert "build(ci): workaround jest snapshot errors in github CI" 

    This reverts commit 6e73cd6.
    Mohan Raj Rajamanickam committed May 29, 2020
    Configuration menu
    Copy the full SHA
    3050c60 View commit details
    Browse the repository at this point in the history

  13. refactor(format): extract unicode chars used in a11y err msg 

    move func to get num of issues from matcher to format
    Mohan Raj Rajamanickam committed May 29, 2020
    Configuration menu
    Copy the full SHA
    58f0459 View commit details
    Browse the repository at this point in the history

  14. style(format): remove unicode chars in a11y err msg 

    to check if it fixes #14
    Mohan Raj Rajamanickam committed May 29, 2020
    Configuration menu
    Copy the full SHA
    dfc39c1 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2020

  1. revert(format): remove print received jest helper 

    to check if it fixes #14
    Mohan Raj Rajamanickam committed May 30, 2020
    Configuration menu
    Copy the full SHA
    72c5e28 View commit details
    Browse the repository at this point in the history

  2. revert(matcher): remove expected, received num of issues from hint 

    check if this fixes #14
    Mohan Raj Rajamanickam committed May 30, 2020
    Configuration menu
    Copy the full SHA
    44fbfc0 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2020

  1. Revert "style(format): remove unicode chars in a11y err msg" 

    This reverts commit dfc39c1.

# Conflicts:
#	packages/assert/__tests__/__snapshots__/assert.test.ts.snap
#	packages/format/__tests__/__snapshots__/format.test.ts.snap
#	packages/jest/__tests__/__snapshots__/matcher.test.ts.snap
    Mohan Raj Rajamanickam committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    95284aa View commit details
    Browse the repository at this point in the history

  2. Revert "revert(format): remove print received jest helper" 

    This reverts commit 72c5e28.

# Conflicts:
#	packages/jest/__tests__/__snapshots__/matcher.test.ts.snap
    Mohan Raj Rajamanickam committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    a6f41b3 View commit details
    Browse the repository at this point in the history

  3. Revert "revert(matcher): remove expected, received num of issues from… 

    … hint"

This reverts commit 44fbfc0.
    Mohan Raj Rajamanickam committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    b4ff445 View commit details
    Browse the repository at this point in the history

  4. revert(format): revert changes to snapshots 

    revert workarounds tested for #14
    Mohan Raj Rajamanickam committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    552332b View commit details
    Browse the repository at this point in the history

  5. build(ci): use test:ci in code cov step 

    for consistency with build step
    Mohan Raj Rajamanickam committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    666b2a0 View commit details
    Browse the repository at this point in the history

  6. build(ci): switch to macos for builds to test #14 

    check if the snapshot errors could be related to OS #14
    Mohan Raj Rajamanickam committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    fc5c181 View commit details
    Browse the repository at this point in the history

  7. Add .circleci/config.yml

    @mohanraj-r
    mohanraj-r committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    9ea7cf6 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'circleci-project-setup' of github.com:salesforce/sa11y … 

    …into refactor_formatter
    Mohan Raj Rajamanickam committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    2691a00 View commit details
    Browse the repository at this point in the history

  9. Revert "build(ci): switch to macos for builds to test #14" 

    This reverts commit fc5c181.
    Mohan Raj Rajamanickam committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    47996ce View commit details
    Browse the repository at this point in the history

  10. ci: switch to node 12

    Mohan Raj Rajamanickam committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    06177cb View commit details
    Browse the repository at this point in the history

  11. ci: fix circle ci config 

    to use docker image tag and new syntax
    Mohan Raj Rajamanickam committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    db350eb View commit details
    Browse the repository at this point in the history

  12. ci: fix node js tag version in circleci config

    Mohan Raj Rajamanickam committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    6989d6f View commit details
    Browse the repository at this point in the history

  13. ci: disable build and test in github ci 

    Due to #14
    Mohan Raj Rajamanickam committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    f804b0d View commit details
    Browse the repository at this point in the history

  14. ci: add codecov artifacts to circleci, fix status badges in readme

    Mohan Raj Rajamanickam committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    376ff12 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2020

  1. refactor(format): add custom error type for a11y errors

    Mohan Raj Rajamanickam committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    c53ff32 View commit details
    Browse the repository at this point in the history

  2. refactor(format): fix default parameters destructuring of format options

    Mohan Raj Rajamanickam committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    c416cfb View commit details
    Browse the repository at this point in the history

  3. refactor(matcher): rename registerA11yMatchers to registerSa11yMatcher 

    as there is only 1 matcher and adding sa11y name to make it easily identifiable
    Mohan Raj Rajamanickam committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    3908974 View commit details
    Browse the repository at this point in the history

  4. docs(contributing): add info about local testing with circle ci

    Mohan Raj Rajamanickam committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    b262833 View commit details
    Browse the repository at this point in the history

  5. feat(format): sort a11y issues by impact

    Mohan Raj Rajamanickam committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    6ce6620 View commit details
    Browse the repository at this point in the history

  6. test(integration): add test to check error thrown for inaccessible dom

    Mohan Raj Rajamanickam committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    d3025b1 View commit details
    Browse the repository at this point in the history

  7. build(format): remove obsolete jest matcher utils dep

    Mohan Raj Rajamanickam committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    fbe7628 View commit details
    Browse the repository at this point in the history

  8. docs: update changelog, readme to add common pkg

    Mohan Raj Rajamanickam committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    179c1fb View commit details
    Browse the repository at this point in the history