-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helm options for config, pullPolicy and apiGroups #154
Conversation
Thanks for the contribution! Before we can merge this, we need @tyrken to sign the Salesforce.com Contributor License Agreement. |
I am glad you fixed the ingress indentation, I was about to push a PR for that but I also have had some other issues with the ingress, I wonder if it worked fine for you |
Sorry didn't use the ingress (I proxy via https://github.com/buzzfeed/sso with it's own ingress) - but if your other issues were an infinite redirect I did get that until I added a non-empty displayContext. Doing so in this PR is a bit of a fudge but not sure how best to "fix" sloop/pkg/sloop/webserver/webserver.go Line 211 in 14ae23c
|
helm/sloop/values.yaml
Outdated
@@ -4,10 +4,11 @@ replicas: 1 | |||
image: | |||
tag: latest | |||
repository: sloopimage/sloop | |||
pullPolicy: Always |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change it to IfNotPresent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @tyrken for the contribution. Overall the change looks good. Just added a small comment.
Done @sana-jawad |
I had to make some changes to the helm chart to get it usable in our cluster, including control over the bits needed from the external values file.
Note I had to define a non-empty displayContext also, to avoid getting stuck in a redirect loop, not sure if this a bug or not.
Sorry my auto-formatting editor has put in a bunch of whitespace fixups, hope you don't mind them included...