Implement multi stage docker build #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @jonnylangefeld to sign the Salesforce.com Contributor License Agreement. |
Makefile
Outdated
| @@ -14,9 +14,7 @@ linux: | |||
| CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go install -ldflags "-s" -installsuffix cgo -v ./pkg/... | |||
|
|
|||
| docker: linux | |||
There was a problem hiding this comment.
you should no longer need the dependency on the linux target right?
There was a problem hiding this comment.
that's right, I removed it
this eliminates local build before docker build fix salesforce#25 Signed-off-by: Jonny Langefeld <jonny.langefeld@gmail.com>
Signed-off-by: Jonny Langefeld <jonny.langefeld@gmail.com>
jonnylangefeld
force-pushed
the
feature/multi-stage-docker-build
branch
from
4015590
to
43e9228
Compare
|
Tested it locally and it works fine. |
thomashargrove
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this eliminates local build before docker build
fix #25
Signed-off-by: Jonny Langefeld jonny.langefeld@gmail.com