Re-add cookie prefix feature #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaterma
reviewed
Dec 3, 2019
| @@ -87,6 +87,12 @@ function checkSameSiteContext(value) { | |||
| } | |||
| } | |||
|
|
|||
| const PrefixSecurityEnum = Object.freeze({ | |||
There was a problem hiding this comment.
That's a very nice way to declare an immutable object. :)
awaterma
approved these changes
Dec 4, 2019
There was a problem hiding this comment.
I think this looks good; tests are clear. Changes are small but consequential. Thanks for the work @ShivanKaul
wjhsf
pushed a commit
that referenced
this pull request
Feb 8, 2024
* feat: prepare for winter21 release (#171) * feat: prepare for winter21 release update lwc to v1.7.10-228.1, @lwc/jest* to 9.0.0-228.0 * chore: update API version to 50.0 * 0.10.0 * fix: jest config to include setupFilesAfterEnv (#174) * 0.10.1 Co-authored-by: Jose David Rodriguez Velasco <jodarove@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #164