fix #256

[hrueger]

by importing .js file and therefore removing the trailing slash

I'm also using Svelte Kit and currently patching this via yarn patch.

[salesforce-cla]

Thanks for the contribution! Before we can merge this, we need @hrueger to sign the Salesforce Inc. Contributor License Agreement.

[hrueger]

I signed the CLA, but then I got an error. Can you please recheck?

[hrueger]

Hm, did I break the tests? That's strange...

[awaterma]

@hrueger -- can you try signing the CLA again? :) Hope you are doing well!

[hrueger]

Yes, thanks. When clicking on the link and logging in with GitHub, I get this:

What to do?

[awaterma]

This change looks good to me; but there's a file conflict. Can you please update your pull request @hrueger? Thank you!

[hrueger]

@awaterma Now that the project is written in typescript, I get ts errors when importing from that javascript file since the @types/punycode packages seems to only support the index export... any idea?

Could not find a declaration file for module 'punycode/punycode.js'. 'a:/_Source/tough-cookie/node_modules/punycode/punycode.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/punycode` if it exists or add a new declaration (.d.ts) file containing `declare module 'punycode/punycode.js';`ts(7016)

[colincasey]

@hrueger it seems like the userland punycode module doesn't play well with Typescript (mathiasbynens/punycode.js#132).

My suggested workaround would be to:

• remove @types/punycode from package.json

• add a custom declaration file like lib/punycode.d.ts which should look something like this:

  declare module 'punycode/punycode.js' {
    // copy the types declared here:
    // https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/punycode/index.d.ts
  }

• change the punycode/ import to punycode/punycode.js

And, since we only use a very small part of the API from punycode, you could possibly just include the type declaration for toASCII and change the import to import { toASCII } from 'punycode/punycode.js'.

[hrueger]

@colincasey I submitted a PR to DefinitelyTyped: DefinitelyTyped/DefinitelyTyped#68273
Let's see if this makes it through ;-)

[hrueger]

@colincasey My DefinitelyTyped PR was merged earlier today, so I updated the package and now the types should be fine 🎉