Enforce explicit function return type #383
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary motivation is to help with #380; enforcing an explicit return type helps us identify which functions return
null
/undefined
and therefore standardize on one value as much as possible.A secondary motivation is that it technically makes type checks faster, as parsing function bodies is no longer necessary to infer the return type. However, given the current size/state of our code, there's no discernible performance gain by enforcing this rule.