Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable use with v8 of webdriverIO #27

Closed
wants to merge 1 commit into from

Conversation

Eddie1802
Copy link

Currently this peerDependency setting blocks the use of wdio-shadowdom-service with webdriverIO v8. I have tested this change on my test suites with wdio v8 and found no issues.

Currently this peerDependency setting blocks the use of wdio-shadowdom-service with webdriverIO v8. I have tested this change on my test suites with wdio v8 and found no issues.
@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @Eddie1802 to sign the Salesforce.com Contributor License Agreement.

@ruudsnl
Copy link

ruudsnl commented Apr 18, 2023

this would be very helpful to update to webdriverio v8!

@nolanlawson
Copy link
Contributor

nolanlawson commented Apr 21, 2023

Thanks for the PR! Technically bumping the peerDependency only removes a warning/error during npm/yarn/pnpm install. I think it might be good if we also test in WebDriver v8, since otherwise we have no idea if it actually works. 😄

Bumping the version here should be good enough:

"webdriverio": "^7.19.2"

Edit: looks like there are other places to bump. Taking a look.

@nolanlawson
Copy link
Contributor

Closed in favor of #29, thanks for opening!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants