Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@W-15398724@ Remove codeCoverage field from non-verbose query response for package version list #723

Merged
merged 6 commits into from
Jul 11, 2024

Conversation

mradulsf
Copy link
Collaborator

@mradulsf mradulsf commented Jul 8, 2024

Ref - WI

@W-15398724@

What does this PR do?

Removing the codeCoverage field from the non-verbose query response for package version list --json

What issues does this PR fix or reference?

codeCoverage was an empty value for non-verbose response, which is incorrect.

@mradulsf mradulsf changed the title @W-15398724@ fix: remove codeCoverage field from non-verbose query for package ver… @W-15398724@ Remove codeCoverage field from non-verbose query response for package version list Jul 8, 2024
Copy link
Collaborator

@t7job t7job left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. Can you add/update a test around this?

test/commands/package/packageVersion.nut.ts Outdated Show resolved Hide resolved
test/commands/package/packageVersion.nut.ts Outdated Show resolved Hide resolved
@mradulsf mradulsf requested a review from t7job July 11, 2024 18:18
@mradulsf
Copy link
Collaborator Author

@WillieRuemmele I guess, it is okay to merge it?

@WillieRuemmele
Copy link
Contributor

QA Notes


✅ : "CodeCoverage": "use --verbose for code coverage", in --json output
✅ : with --verbose -> "CodeCoverage": "100%",, or "CodeCoverage": "",

@WillieRuemmele WillieRuemmele merged commit dc42ab9 into main Jul 11, 2024
10 of 12 checks passed
@WillieRuemmele WillieRuemmele deleted the mradul/packaging/W-15398724/fix-verbose branch July 11, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants