fix: stop spinners on caught error

salesforcecli · Sep 28, 2023 · c3242a7 · c3242a7
1 parent 34dde27
commit c3242a7
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/sfCommand.ts b/src/sfCommand.ts
@@ -415,6 +415,9 @@ export abstract class SfCommand<T> extends Command {
 
   // eslint-disable-next-line @typescript-eslint/require-await
   protected async catch(error: Error | SfError | SfCommand.Error): Promise<SfCommand.Error> {
+    // stop any spinners to prevent it from unintentionally swallowing output.
+    // If there is an active spinner, it'll say "Error" instead of "Done"
+    this.spinner.stop(StandardColors.error('Error'));
     // transform an unknown error into one that conforms to the interface
 
     // @ts-expect-error because exitCode is not on Error