fix: extract handler transform for ut, handle undefined #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the error catch on SfError is doing some transformation for sfError.
it's possible to have a
context: undefinedon the sfError.in existing logic for
context in errorto return true (prop exists, not that it is necessarily defined)context: 'context' in error ? error.context : this.statics.name,so that context stays undefined
NUTs caught this here https://github.com/salesforcecli/plugin-source/actions/runs/8636061623/job/23675553032?pr=1153#step:13:246
Note: this could be a behavior change in SfError's handling of undefined context, but using sfCommand to ensure that context comes off the command also fixes it (and probably fixes it better since sfCommand has access to the command name that we use as a backup).