Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend allowed characters in InstanceMethods.convert_text #92

Open
kiriakosv opened this issue Nov 11, 2020 · 3 comments · May be fixed by #105
Open

Extend allowed characters in InstanceMethods.convert_text #92

kiriakosv opened this issue Nov 11, 2020 · 3 comments · May be fixed by #105

Comments

@kiriakosv
Copy link

Hello,

we're using this gem to initiate credit transfers for Greek banks.

The problem is that names of initiating parties and account beneficiaries can be in Greek. As we see here, the only letter characters allowed are Latin and German. This results in empty strings and therefore validation errors.

Would you accept a PR that adds Greek letters to the allowed set?

@flooose
Copy link

flooose commented Mar 12, 2021

We've got a similar issue with letters that have diacritics (áéó, and co. :) ).

According to the Excel sheet on the page you link to here, there should also be a lot more supported characters.

I'd also be happy to help with an MR. If it was just a handful of characters, I'd simply go ahead and submit the PR, but there with so many that aren't supported right now, that could turn into an unwieldy regex :)

@kiriakosv do you have any thoughts on this?

@kiriakosv kiriakosv changed the title Allow greek characters in InstanceMethods.convert_text Extend allowed characters in InstanceMethods.convert_text Mar 13, 2021
@stayhero
Copy link
Contributor

We are having a similar issue with cyrillic characters (Bulgarian account holder). I would prefer if the suggested conversion table (according to the linked Excel sheet) could be used, instead of just converting non-latin characters to an empty character (e.g. 'И' would become 'I').

The PR only extends the allowed chars but I guess the better solution would be to translate the characters according to the EPC217-08 conversion table? Would you be interested in a PR?

@kiriakosv
Copy link
Author

kiriakosv commented Feb 26, 2022

We are having a similar issue with cyrillic characters (Bulgarian account holder). I would prefer if the suggested conversion table (according to the linked Excel sheet) could be used, instead of just converting non-latin characters to an empty character (e.g. 'И' would become 'I').

The PR only extends the allowed chars but I guess the better solution would be to translate the characters according to the EPC217-08 conversion table? Would you be interested in a PR?

Sure! I'll have a PR open by 28/2.

@kiriakosv kiriakosv linked a pull request Feb 28, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants