Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove accidentally commited binstub. Fixes #79 #80

Merged
merged 1 commit into from Oct 8, 2018
Merged

Remove accidentally commited binstub. Fixes #79 #80

merged 1 commit into from Oct 8, 2018

Conversation

leoarnold
Copy link
Contributor

The binstub bin/rake was accidentally added in
7cdb97b
and is prone to break projects using rake.

This commit removes the binstub as well as the executables file list
from the gemspec to prevent unintended additions of executables
in future commits.

The binstub bin/rake was accidentally added in
7cdb97b
and is prone to break projects using rake.

This commit removes the binstub as well as the executables file list
from the gemspec to prevent unintended additions of executables
in future commits.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c1d0e69 on leoarnold:fix/binstubs into fd63435 on salesking:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c1d0e69 on leoarnold:fix/binstubs into fd63435 on salesking:master.

@ledermann ledermann merged commit 5bb1368 into salesking:master Oct 8, 2018
@ledermann
Copy link
Member

Thank you!

@leoarnold leoarnold deleted the fix/binstubs branch October 8, 2018 17:28
@leoarnold
Copy link
Contributor Author

👍 Already released as v0.11.2 👏

rogercampos pushed a commit to factorialco/sepa_king that referenced this pull request Feb 16, 2023
The binstub bin/rake was accidentally added in
salesking@7cdb97b
and is prone to break projects using rake.

This commit removes the binstub as well as the executables file list
from the gemspec to prevent unintended additions of executables
in future commits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants