feat(login_user): send 401 if email not exists

salgode · Nov 2, 2019 · dc003de · dc003de
1 parent 2501d9d
commit dc003de
Showing 1 changed file with 33 additions and 29 deletions.
diff --git a/login_user.js b/login_user.js
@@ -44,43 +44,50 @@ exports.handler = async (event) => {
   const body = JSON.parse(event.body);
   const loginEmail = body.email;
   const loginPassword = body.password;
-  const userFromLogin = await getUserFromLogin(loginEmail);
-  const hashedPassword = userFromLogin.password_hash;
+  const userFromDb = await getUserFromLogin(loginEmail);
 
-  const selfieUrl = userFromLogin.user_identifications.selfie_image
-    ? await getImageUrl(userFromLogin.user_identifications.selfie_image)
+  if (!userFromDb) {
+    return {
+      statusCode: 401,
+      headers: { 'Access-Control-Allow-Origin': '*' },
+      body: JSON.stringify({ message: 'Unauthorized' })
+    };
+  }
+
+  const selfieUrl = userFromDb.user_identifications.selfie_image
+    ? await getImageUrl(userFromDb.user_identifications.selfie_image)
     : null;
-  const identFrontUrl = userFromLogin.user_identifications.identification.front
-    ? await getImageUrl(userFromLogin.user_identifications.identification.front)
+  const identFrontUrl = userFromDb.user_identifications.identification.front
+    ? await getImageUrl(userFromDb.user_identifications.identification.front)
     : null;
-  const identBackUrl = userFromLogin.user_identifications.identification.back
-    ? await getImageUrl(userFromLogin.user_identifications.identification.back)
+  const identBackUrl = userFromDb.user_identifications.identification.back
+    ? await getImageUrl(userFromDb.user_identifications.identification.back)
     : null;
-  const driverFrontUrl = userFromLogin.user_identifications.driver_license.front
-    ? await getImageUrl(userFromLogin.user_identifications.driver_license.front)
+  const driverFrontUrl = userFromDb.user_identifications.driver_license.front
+    ? await getImageUrl(userFromDb.user_identifications.driver_license.front)
     : null;
-  const driverBackUrl = userFromLogin.user_identifications.driver_license.back
-    ? await getImageUrl(userFromLogin.user_identifications.driver_license.back)
+  const driverBackUrl = userFromDb.user_identifications.driver_license.back
+    ? await getImageUrl(userFromDb.user_identifications.driver_license.back)
     : null;
 
-  if (bcrypt.compareSync(loginPassword, hashedPassword)) {
+  if (bcrypt.compareSync(loginPassword, userFromDb.password_hash)) {
     const responseBody = {
-      bearer_token: userFromLogin.bearer_token,
-      user_id: userFromLogin.user_id,
-      first_name: userFromLogin.first_name,
-      last_name: userFromLogin.last_name,
-      email: userFromLogin.email,
-      phone: userFromLogin.phone,
+      bearer_token: userFromDb.bearer_token,
+      user_id: userFromDb.user_id,
+      first_name: userFromDb.first_name,
+      last_name: userFromDb.last_name,
+      email: userFromDb.email,
+      phone: userFromDb.phone,
       avatar: selfieUrl,
       user_verifications: {
-        email: userFromLogin.user_verifications.email,
-        phone: userFromLogin.user_verifications.phone,
+        email: userFromDb.user_verifications.email,
+        phone: userFromDb.user_verifications.phone,
         identity:
-          userFromLogin.user_verifications.identification.front
-          && userFromLogin.user_verifications.identification.back,
+          userFromDb.user_verifications.identification.front
+          && userFromDb.user_verifications.identification.back,
         driver_license:
-          userFromLogin.user_verifications.driver_license.front
-          && userFromLogin.user_verifications.driver_license.back
+          userFromDb.user_verifications.driver_license.front
+          && userFromDb.user_verifications.driver_license.back
       },
       user_identifications: {
         selfie: selfieUrl,
@@ -100,12 +107,9 @@ exports.handler = async (event) => {
       body: JSON.stringify(responseBody)
     };
   }
-  const responseBody = {
-    message: 'Unauthorized'
-  };
   return {
     statusCode: 401,
     headers: { 'Access-Control-Allow-Origin': '*' },
-    body: JSON.stringify(responseBody)
+    body: JSON.stringify({ message: 'Unauthorized' })
   };
 };