Skip to content

Commit

Permalink
fix(get_driver_trip_manifest): fix when no reservations and add robus…
Browse files Browse the repository at this point in the history
…tness
  • Loading branch information
Franco Méndez committed Oct 31, 2019
1 parent ce17c72 commit f1666ee
Showing 1 changed file with 13 additions and 13 deletions.
26 changes: 13 additions & 13 deletions get_driver_trip_manifest.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ function repeated(value, index, self) {
}

async function getTrip(tripId) {
console.log('in getTrip');
const params = {
TableName: TripsTableName,
Key: {
Expand All @@ -33,7 +32,6 @@ async function getTrip(tripId) {
}

async function getReservations(tripId) {
console.log('in getReservations');
const params = {
TableName: ReservationsTableName,
IndexName: ReservationsIndexName,
Expand All @@ -50,7 +48,6 @@ async function getReservations(tripId) {
}

async function getPlaces(placeIds) {
console.log('in getPlaces');
const params = {
RequestItems: {
[PlacesTableName]: {
Expand All @@ -66,7 +63,6 @@ async function getPlaces(placeIds) {
}

async function getPassengers(passengerIds) {
console.log('in getPassengers');
const params = {
RequestItems: {
[UsersTableName]: {
Expand All @@ -89,7 +85,7 @@ function mergeAssign(reservations, passengers, places) {
for (let i = 0; i < reservations.length; i += 1) {
start = places.find((p) => p.place_id === reservations[i].route.start);
end = places.find((p) => p.place_id === reservations[i].route.end);
passenger = passengers.find((p) => p.user_id);
passenger = passengers.find((p) => p.user_id === reservations[i].passenger_id);
data.push({
passenger_id: passenger.user_id,
passenger_name: passenger.first_name,
Expand All @@ -105,23 +101,27 @@ function mergeAssign(reservations, passengers, places) {

exports.handler = async (event) => {
const tripId = event.pathParameters.trip;
console.log('tripId', tripId);
const trip = await getTrip(tripId);
console.log('trip', trip);

const reservations = await getReservations(tripId);
console.log('reservations', reservations);
if (!(reservations.length > 0)) {
return {
statusCode: 200,
headers: { 'Access-Control-Allow-Origin': '*' },
body: JSON.stringify({
trip_id: tripId,
passengers: []
})
};
}
const passengerIdsRaw = reservations.map((r) => r.passenger_id);
const passengerIds = passengerIdsRaw.filter(repeated);
console.log('passengerIds', passengerIds);

const passengers = await getPassengers(passengerIds);
console.log('passengers', passengers);
const places = await getPlaces(trip.route_points);
console.log('places', places);
const placesIds = trip.route_points.map((rp) => rp).filter(repeated);
const places = await getPlaces(placesIds);

const data = mergeAssign(reservations, passengers, places);
console.log('data', data);

const bodyResponse = {
trip_id: trip.trip_id,
Expand Down

0 comments on commit f1666ee

Please sign in to comment.