Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colorful reactive ripple effect #81

Merged
merged 2 commits into from
May 29, 2023

Conversation

augustoicaro
Copy link
Contributor

Hello Salih,

Last week I was testing the effects implemented in the indicator because I was inspired to implement a cross effect that I saw in the planck ez keyboard review video. Later I figured out that the effect is only interesting in ortholinear keyboards. So I changed my goal to adapt the reactive ripple effect to the idea that I had in my mind. I'm very satisfied with the results and decided to share the option here.

During the development, I found a bug with the deque that crashed the indicator application due to a mutation in the deque during a for loop. I add a commit to fix that.

Thanks again for your work on this indicator.

Ps. I love your idea of the ester egg. I keep that in the new effect.

@salihmarangoz
Copy link
Owner

Wow, that's nice! Thank you for the effect and bug fix. I will be adding combined_mouse_and_reactive_keyboard_colorful.py to combine it with the mouse effect. Keeping the easter egg is a nice touch :)

@salihmarangoz salihmarangoz merged commit 0123954 into salihmarangoz:main May 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants