Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mouse effects with ripples for scroll and click #83

Merged
merged 1 commit into from
May 30, 2023

Conversation

augustoicaro
Copy link
Contributor

Hello Salih,

Thank you for the updates! I liked the new juggling effect!

I was messing around with the new mouse + keyboard effect, and as a non-heavy mouse user, I noticed that I was missing a reaction for the mouse scroll. So I improved the mouse code to listen to the mouse scroll and click and added the ripple effect to each one.

@salihmarangoz
Copy link
Owner

Wow, super nice, again! Wait for my version of this :)

@salihmarangoz salihmarangoz merged commit 17bc4ea into salihmarangoz:main May 30, 2023
3 checks passed
@salihmarangoz
Copy link
Owner

I added a better scroll effect with 0b3fcb1 @augustoicaro :)

@augustoicaro
Copy link
Contributor Author

augustoicaro commented May 30, 2023

I liked your version. The shift effect combines better with the scroll. It was a clever idea to use the circles to create the background.

@augustoicaro
Copy link
Contributor Author

augustoicaro commented May 30, 2023

@salihmarangoz , about the commit 0b3fcb1 , what was the bug fix? Was moving the initialization of ripple_list in rgb_kb_custom/reactive_keyboard_colorful.py? I think I didn't find it.

@salihmarangoz
Copy link
Owner

@augustoicaro , There is a rare case where self.keyboard_mapper = KeyboardMapper(self.keyboard_cb) may call the callback directly if a key is pressed at that time. It did happen a few times so I fixed this problem.

For self.mouse = Controller() it was not needed to move it. My bad :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants