Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle mismatched static info in rmf_cat #128

Closed
benmwebb opened this issue Feb 16, 2024 · 1 comment
Closed

Handle mismatched static info in rmf_cat #128

benmwebb opened this issue Feb 16, 2024 · 1 comment
Assignees
Labels

Comments

@benmwebb
Copy link
Member

@alatham13

rmf_cat simply copies the static frame from the first RMF to the output file, then adds all non-static frames from all RMFs to the output. This generates incorrect RMFs and/or loses information when the static frames in the input RMFs are different.

For example, a rigid body is typically handled by storing component body-frame coordinates in the static frame, and the body's reference frame (which changes during a simulation) to the non-static frames. If these body-frame coordinates are different in the input RMF files (for example, if a different initial reference frame and thus mapping from global to body-frame coordinates was chosen) then the output RMF will include some non-static reference frames which don't match the static body-frame coordinates.

rmf_cat should check for mismatched static frames and warn or error out in the general case. For the specific case of rigid bodies, in principle the non-static reference frames could be transformed to match the static coordinates.

@benmwebb benmwebb added the bug label Feb 16, 2024
@benmwebb benmwebb self-assigned this Feb 16, 2024
@alatham13
Copy link

This is great, thanks @benmwebb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants