replace in_array with isset for faster redis command execution with n…

…amespace update
salimane · Sep 1, 2012 · c510e7d · c510e7d
1 parent ac2d38d
commit c510e7d
Show file tree

Hide file tree

Showing 2 changed files with 84 additions and 84 deletions.
diff --git a/lib/Resque/Redis.php b/lib/Resque/Redis.php
@@ -26,47 +26,47 @@ class Resque_Redis extends Redisent
 	 *	first argument. Used to prefix keys with the Resque namespace.
 	 */
 	private $keyCommands = array(
-		'exists',
-		'del',
-		'type',
-		'keys',
-		'expire',
-		'ttl',
-		'move',
-		'set',
-		'get',
-		'getset',
-		'setnx',
-		'incr',
-		'incrby',
-		'decr',
-		'decrby',
-		'rpush',
-		'lpush',
-		'llen',
-		'lrange',
-		'ltrim',
-		'lindex',
-		'lset',
-		'lrem',
-		'lpop',
-		'rpop',
-		'sadd',
-		'srem',
-		'spop',
-		'scard',
-		'sismember',
-		'smembers',
-		'srandmember',
-		'zadd',
-		'zrem',
-		'zrange',
-		'zrevrange',
-		'zrangebyscore',
-		'zcard',
-		'zscore',
-		'zremrangebyscore',
-		'sort'
+		'exists' => 'exists',
+		'del' => 'del',
+		'type' => 'type',
+		'keys' => 'keys',
+		'expire' => 'expire',
+		'ttl' => 'ttl',
+		'move' => 'move',
+		'set' => 'set',
+		'get' => 'get',
+		'getset' => 'getset',
+		'setnx' => 'setnx',
+		'incr' => 'incr',
+		'incrby' => 'incrby',
+		'decr' => 'decr',
+		'decrby' => 'decrby',
+		'rpush' => 'rpush',
+		'lpush' => 'lpush',
+		'llen' => 'llen',
+		'lrange' => 'lrange',
+		'ltrim' => 'ltrim',
+		'lindex' => 'lindex',
+		'lset' => 'lset',
+		'lrem' => 'lrem',
+		'lpop' => 'lpop',
+		'rpop' => 'rpop',
+		'sadd' => 'sadd',
+		'srem' => 'srem',
+		'spop' => 'spop',
+		'scard' => 'scard',
+		'sismember' => 'sismember',
+		'smembers' => 'smembers',
+		'srandmember' => 'srandmember',
+		'zadd' => 'zadd',
+		'zrem' => 'zrem',
+		'zrange' => 'zrange',
+		'zrevrange' => 'zrevrange',
+		'zrangebyscore' => 'zrangebyscore',
+		'zcard' => 'zcard',
+		'zscore' => 'zscore',
+		'zremrangebyscore' => 'zremrangebyscore',
+		'sort' => 'sort'
 	);
 	// sinterstore
 	// sunion
@@ -104,7 +104,7 @@ public static function prefix($namespace)
 	 */
 	public function __call($name, $args) {
 		$args = func_get_args();
-		if(in_array($name, $this->keyCommands)) {
+		if(isset($this->keyCommands[$name])) {
 		    $args[1][0] = self::$defaultNamespace . $args[1][0];
 		}
 		try {

diff --git a/lib/Resque/RedisCluster.php b/lib/Resque/RedisCluster.php
@@ -26,47 +26,47 @@ class Resque_RedisCluster extends RedisentCluster
 	 *	first argument. Used to prefix keys with the Resque namespace.
 	 */
 	private $keyCommands = array(
-		'exists',
-		'del',
-		'type',
-		'keys',
-		'expire',
-		'ttl',
-		'move',
-		'set',
-		'get',
-		'getset',
-		'setnx',
-		'incr',
-		'incrby',
-		'decrby',
-		'decrby',
-		'rpush',
-		'lpush',
-		'llen',
-		'lrange',
-		'ltrim',
-		'lindex',
-		'lset',
-		'lrem',
-		'lpop',
-		'rpop',
-		'sadd',
-		'srem',
-		'spop',
-		'scard',
-		'sismember',
-		'smembers',
-		'srandmember',
-		'zadd',
-		'zrem',
-		'zrange',
-		'zrevrange',
-		'zrangebyscore',
-		'zcard',
-		'zscore',
-		'zremrangebyscore',
-		'sort'
+		'exists' => 'exists',
+		'del' => 'del',
+		'type' => 'type',
+		'keys' => 'keys',
+		'expire' => 'expire',
+		'ttl' => 'ttl',
+		'move' => 'move',
+		'set' => 'set',
+		'get' => 'get',
+		'getset' => 'getset',
+		'setnx' => 'setnx',
+		'incr' => 'incr',
+		'incrby' => 'incrby',
+		'decr' => 'decr',
+		'decrby' => 'decrby',
+		'rpush' => 'rpush',
+		'lpush' => 'lpush',
+		'llen' => 'llen',
+		'lrange' => 'lrange',
+		'ltrim' => 'ltrim',
+		'lindex' => 'lindex',
+		'lset' => 'lset',
+		'lrem' => 'lrem',
+		'lpop' => 'lpop',
+		'rpop' => 'rpop',
+		'sadd' => 'sadd',
+		'srem' => 'srem',
+		'spop' => 'spop',
+		'scard' => 'scard',
+		'sismember' => 'sismember',
+		'smembers' => 'smembers',
+		'srandmember' => 'srandmember',
+		'zadd' => 'zadd',
+		'zrem' => 'zrem',
+		'zrange' => 'zrange',
+		'zrevrange' => 'zrevrange',
+		'zrangebyscore' => 'zrangebyscore',
+		'zcard' => 'zcard',
+		'zscore' => 'zscore',
+		'zremrangebyscore' => 'zremrangebyscore',
+		'sort' => 'sort'
 	);
 	// sinterstore
 	// sunion
@@ -104,7 +104,7 @@ public static function prefix($namespace)
 	 */
 	public function __call($name, $args) {
 		$args = func_get_args();
-		if(in_array($name, $this->keyCommands)) {
+		if(isset($this->keyCommands[$name])) {
 			$args[1][0] = self::$defaultNamespace . $args[1][0];
 		}
 		try {