Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using LALRPOP #40

Closed
KiChjang opened this issue May 4, 2019 · 2 comments
Closed

Consider using LALRPOP #40

KiChjang opened this issue May 4, 2019 · 2 comments

Comments

@KiChjang
Copy link
Collaborator

KiChjang commented May 4, 2019

I've been recently contributing to chalk, the traits solver for rustc and they're currently using LALRPOP for their parsing needs. It has a separate file in which you define your grammar, which has a Rust-like syntax and looks almost like an ABNF form for your language. Maybe we can look into it so that you can easily add more tokens and production rules for razor in the future?

@KiChjang
Copy link
Collaborator Author

KiChjang commented May 4, 2019

@salmans
Copy link
Owner

salmans commented May 5, 2019

This looks great! I definitely want to to give it a try. The current parser in nom can be improved: I just worked on this PR: #41 for example but error handling is not good at all. So why not trying LALRPOP.
Alternatively, we can implement a TPTP in Rust and use it in Razor: http://www.tptp.org

salmans added a commit that referenced this issue Sep 8, 2021
removing the nom parser and dependencies to related crates.
closes #40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants