implementation based on relational algebra #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new module for relationalizing formulae Initial review for relationalization and conversion to relational expressions
first iteration of cleaning up the code
fixes a major bug where only the same branch of a sequent extended a model where multiple tuples were relevant fixes expression memoization (did not work before) adds core tests for the relational implementation
moving equality expansion out of relationalization adding Relational wrapper around Formula resetting Relationalizer before each transformation so it can be used to translate multiple formulae
this change removes unnecessary atoms from branches to improve performance creating a new sequent now returns a result type instead of panicking immediately
remove existential variables in favor of universal or other existential variables that are equal to it
the relational implementation contracts models based on equality on elements
using unstable feature of codd and updating codd macros according to the latest changes
salmans
commented
Nov 10, 2020
…mentation fixes a bug where incorrect models for grandpa.raz were being produced
removing the inner value that carried the attribute which is equal to the equational attribute removing canonicalization of attributes
adding AttributeList::new() to create an instance from an iterator of attributes implementing TryFrom<Formula> for AttributeList
This was referenced Nov 15, 2020
Closed
Fixes a bug where memoizing expressions was not done correctly Plus other minor changes and enhancements to address PR comments
salmans
commented
Nov 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.