Sign in with G+ doesn't work

[herval]

(nothing happens when you click the button)

[salomvary]

Had a quick look, SoundCloud switched to opening yet another popup from the login popup for G+ at some point and thats what SoundCleod is not prepared for. Will try to find a quick fix/hack.

[salomvary]

The problem lies in PopupController, which doesn't have a way of opening another popup.

Relatively easy solution would be to implement (WebView *)webView:(WebView *)sender createWebViewWithRequest:(NSURLRequest *)request in PopupController and create a new WebView every time a popup is requested from the popup, and replace the view in the window.

What makes it complicated is that every popup webview has to be kept alive until closed by themselves. Sounds like an array of webviews...

Any volunteers to implement this?

[gootik]

Is the same thing happening with FB? I can't login

[mttkay]

👍

Can't log into my account :(

[salomvary]

Yeah, I know it's a pain. Unfortunately not trivial to support, thanks to soundcloud.com opening popups opening other popups, etc.

Will try to look into it in the near future unless someone wants to volunteer..

[salomvary]

Started some work in fix-google-login, still no success. Apparently making G+ popups work requires proper handling of window-and-it's-opener relations and opening windows by name on javascript level which seems to be nearly impossible on Cocoa/WebView. Especially making window.open('some url', 'name of an existing window') scenario work as expected.

[salomvary]

Fixed in 1.0.0.