Issue getting body() / json() with Laravel

[pboese]

Heya,

I have a weird problem. We're using Laravel 10 with the latest Saloon Laravel implementation. When fetching data using a request,
$response->body() is always empty and $response->json() throws an "Syntax error".

Saloon\Http\Response {#908 ▼ // app/Actions/ShopwareStorefront/GetMedia.php:21
  #psrResponse: GuzzleHttp\Psr7\Response {[#933 ▼](https://marks-wawi.local:7890/shopwarestorefront/media/d57af604b3a04d81995fd345f536258f#sf-dump-1492796798-ref2933)
    -reasonPhrase: "OK"
    -statusCode: 200
    -headers: array:16 [▶]
    -headerNames: array:16 [▶]
    -protocol: "1.1"
    -stream: GuzzleHttp\Psr7\Stream {#936 ▶}
  }
  #pendingRequest: Saloon\Http\PendingRequest {#846 ▶}
  #senderException: null
  #mocked: false
  #cached: false
  #simulatedResponsePayload: null
}

The only way I have found to get the JSON body is to use the psrResponse object:

json_decode($response->getPsrResponse()->getBody());

We're using the Laravel HTTP Sender but also tried the Guzzle Sender, the result is always the same.

Our code looks like this:

Connector:

<?php

namespace App\Http\Integrations\Shopware;

use Saloon\Helpers\OAuth2\OAuthConfig;
use Saloon\Http\Connector;
use Saloon\Traits\OAuth2\ClientCredentialsGrant;
use Saloon\Traits\Plugins\AcceptsJson;

class ShopwareConnector extends Connector
{
    use AcceptsJson;
    use ClientCredentialsGrant;

    /**
     * The Base URL of the API
     */
    public function resolveBaseUrl(): string
    {
        return config('shopware.url');
    }

    /**
     * Default headers for every request
     *
     * @return string[]
     */
    protected function defaultOauthConfig(): OAuthConfig
    {
        return OAuthConfig::make()
            ->setClientId(config('shopware.access_key_id'))
            ->setClientSecret(config('shopware.access_key_secret'))
            ->setTokenEndpoint('/api/oauth/token');
    }

    /**
     * Default headers for every request
     *
     * @return string[]
     */
    protected function defaultHeaders(): array
    {
        return [
            'Accept' => 'application/vnd.api+json, application/json',
        ];
    }

    /**
     * Default HTTP client options
     *
     * @return string[]
     */
    protected function defaultConfig(): array
    {
        return [
            'timeout' => 60,
        ];
    }
}

Request:

<?php

namespace App\Http\Integrations\Shopware\Requests\Media;

use Saloon\Contracts\Body\HasBody;
use Saloon\Enums\Method;
use Saloon\Http\Request;
use Saloon\Traits\Body\HasJsonBody;

class GetMediaRequest extends Request implements HasBody
{
    use HasJsonBody;

    /**
     * Define the HTTP method
     */
    protected Method $method = Method::GET;

    /**
     * Define the endpoint for the request
     */
    public function resolveEndpoint(): string
    {
        return '/api/media/'.$this->id;
    }

    /**
     * Constructor
     */
    public function __construct(
        protected string $id,
    ) {
    }
}

And then we use it like:

$request = new GetMediaRequest(id: $mediaId);

$response = $this->shopware->send($request);

[Sammyjo20]

Hey @pboese I think this is related to #256 - I will get this PR released ASAP :)

[Sammyjo20]

I believe you can get around it for now by doing $response->stream()->rewind() before accessing your body

[pboese]

Ahhhh, thanks a lot, I didn't find this issue 👍 This is exactly the problem!