Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: UrlHelper join method handle endpoint URL string #101

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

ashleyhood
Copy link
Contributor

This is to allow API endpoints to be full URLs and not have the baseUrl prepended to it. Closes issue #99

@what-the-diff
Copy link

what-the-diff bot commented Nov 7, 2022

  • Added a new method to check if the url is valid
  • Updated join() method to return endpoint when it's already an absolute URL
  • Removed unnecessary code in join() that checks for $endpointIsNotUrl and sets glue variable accordingly, since we're now returning early from this function when endpoint is already an absolute URL (see Added tests #1)

Copy link
Collaborator

@Sammyjo20 Sammyjo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@Sammyjo20 Sammyjo20 merged commit ab3797e into saloonphp:v1 Nov 7, 2022
@ashleyhood ashleyhood deleted the enhance_urlhelper_join branch November 7, 2022 19:23
@Gummibeer
Copy link
Contributor

Thanks! 🎉🚀

Gummibeer added a commit to Astrotomic/steam-sdk that referenced this pull request Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants