Fixed handler stack #112
Merged
Fixed handler stack #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if this is fixed now - my problem was that I had a request that returned a 401 response, I got the exception (from my sdk response) but the fixture file wasn't created. So the test would do a real request every single time and needs a correct access token. Which isn't the sense of fixtures and wasn't like that in v1. |
|
This is what I mentioned in issue #64 - I think we need to have a middleware priority or the ability to add a middleware to the top of the stack - like the fixture recording middleware, so that it can still record the response and then throw the exception. |
|
Sounds good - like request middlewares in Laravel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Gummibeer I think you mentioned that Guzzle wasn't throwing exceptions on error requests, you were right - my old way of defining the handler stack meant the default middleware wasn't being applied. I've moved the logic to use the same as v1, and it works again now!