Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature | V2 - Replace method with enum #127

Merged
merged 5 commits into from
Dec 11, 2022
Merged

Conversation

Sammyjo20
Copy link
Collaborator

This PR replaces the old string-based method on requests with an enum to be strongly typed.

@Sammyjo20 Sammyjo20 changed the base branch from v1 to v2 December 11, 2022 19:23
@what-the-diff
Copy link

what-the-diff bot commented Dec 11, 2022

  • Changed the method type from string to enum
  • Added a new case for HEAD in Method Enum
  • Removed upperFrom function and added default null value in match statement of getMessage() function
  • Updated all requests with correct methods (GET, POST etc) instead of strings as they were before this change was made
  • Fixed some typos that I found while reviewing codebase
  • Changed the method property type from string to Method enum.
  • Added use statement for Saloon\Enums\Method; in all files where it was missing.
  • Changed the method property from string to Method enum.
  • Added use statement for Saloon\Enums\Method; in all files where it was missing.
  • Changed the method property type from string to Method enum.
  • Added use statement for Method Enum in each file where it was used as a property type.

@Sammyjo20 Sammyjo20 marked this pull request as ready for review December 11, 2022 19:26
Copy link
Collaborator Author

@Sammyjo20 Sammyjo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review

@Sammyjo20 Sammyjo20 merged commit cd6631e into v2 Dec 11, 2022
@Sammyjo20 Sammyjo20 deleted the feature/use-method-enum branch December 27, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant