Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature | Added dataUrl for Response #377

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

guanguans
Copy link
Contributor

No description provided.

@Sammyjo20
Copy link
Collaborator

Hey, @guanguans thank you for submitting this PR - I think this is a cool addition to Saloon! I'm going to have a quick look over the PR but I think the implementation is solid.

Copy link
Collaborator

@Sammyjo20 Sammyjo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion - would it be better to used the camel-case variant for Content-Type? I guess it's up to the PSR-7 implementation behind the scenes on how it handles it, but I'm pretty sure Guzzle normalises it anyway.

src/Http/Response.php Outdated Show resolved Hide resolved
Copy link
Collaborator

@Sammyjo20 Sammyjo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I will release this later. Thanks again!

@Sammyjo20 Sammyjo20 merged commit 1830bf8 into saloonphp:v3 Feb 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants