Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature | Add a NullAuthenticator to overwrite defaultAuth #423

Merged
merged 4 commits into from
Jun 9, 2024

Conversation

patrickcarlohickman
Copy link
Contributor

This PR adds a NullAuthenticator class that allows a user to use the null object pattern, and provides a way to remove an authenticator that has already been set.

This has been addressed in #402 and #385.

This PR only adds a new file, so it should not have any backwards compatibility issues.

@Sammyjo20 Sammyjo20 changed the title Add a null authenticator implementation. Feature | Add a NullAuthenticator to overwrite defaultAuth Jun 9, 2024
Copy link
Collaborator

@Sammyjo20 Sammyjo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution, thanks @patrickcarlohickman!

@Sammyjo20 Sammyjo20 merged commit ea50417 into saloonphp:v3 Jun 9, 2024
14 checks passed
@jlevers
Copy link

jlevers commented Jun 10, 2024

Ah, thanks @patrickcarlohickman! I've been meaning to submit a similar PR for a few weeks now. Good stuff :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants