Small fixes to calc tutorial #420
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct typos and make some sentences more explicit
Add anchor for `Default` implementation (through derive)
Correct some sentences from previous versions
Explicit some abbreviations. Add some indications for better text flow. Correct the heading levels. Include some missing references in code. Unify presentation style accross sections. Change "id" for "struct" in interned context (for consistency)
This reads better in the tutorial, as the use statements will be part of the presented code
Correct typo. Deduplicate text. Update text to code.
Rephrase for better reading flow.
Fix typo
Source code documentation fixes
✅ Deploy Preview for salsa-rs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Excited about salsa, I was reading the
calctutorial in the book and thought that would be useful to contribute the small fixes I would make.Most of the changes are typos, updating according to the code or rephrasing for a smoother reading flow. Feel free to accept or reject any of the changes: there is no such thing as the "best writing style".