Manual Debug impl for salsa::Id
#508
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
nikomatsakis
requested changes
Jun 23, 2024
src/id.rs
Outdated
| @@ -40,6 +40,12 @@ impl Id { | |||
| } | |||
| } | |||
|
|
|||
| impl std::fmt::Debug for Id { | |||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | |||
| self.as_u32().fmt(f) | |||
There was a problem hiding this comment.
Hmm. I think it would be better to print something other than just a number -- e.g., Id(N). I've usually found there is value in having some more "grep-able".
I think yes :)
I like that it uses the debug impl, keep that I think. |
MichaReiser
force-pushed
the
id-manual-debug-impl
branch
from
c900790
to
2f42fc5
Compare
MichaReiser
force-pushed
the
id-manual-debug-impl
branch
from
2f42fc5
to
ff0bcd6
Compare
MichaReiser
force-pushed
the
id-manual-debug-impl
branch
from
ff0bcd6
to
662c58f
Compare
MichaReiser
commented
Jun 23, 2024
tests/tracked_with_struct_db.rs
Outdated
Comment on lines
58
to
60
| [salsa id]: Id( | ||
| 0, | ||
| ), |
There was a problem hiding this comment.
Okay, the fact that debug_tuple splits the ID across multiple lines in alternate mode is too verbose. I'm just gonna use a regular write call.
MichaReiser
force-pushed
the
id-manual-debug-impl
branch
from
53c3cf7
to
94f36f0
Compare
MichaReiser
force-pushed
the
id-manual-debug-impl
branch
from
94f36f0
to
5751cb3
Compare
|
I updated the Debug implementation to write |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've often been confused by the fact that the IDs printed by
DebugWithDbdon't match with the ids printed when dumping asalsa::IdwithDebug.This PR replaces the derived
Debugimplementation ofsalsa::Idwith a manualDebugimplementation that ensures that the IDs printed byDebugandDebugWithdbare consistent.Open Questions
Idusef.debug_tupleto preserve the name in theDebugoutput?DebugWithDbcontinue to useas_u32directly or should it just call theId'sDebugimplementation (It would change the output if we decide thatDebugshould outputId(num).