Skip to content

Commit

Permalink
Use a database that supports concurrent connections
Browse files Browse the repository at this point in the history
  • Loading branch information
will89 committed Oct 14, 2020
1 parent 1b199db commit ad1f6a6
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 16 deletions.
8 changes: 1 addition & 7 deletions delayed_job_heartbeat_plugin.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,9 @@ Gem::Specification.new do |spec|
spec.add_development_dependency 'activerecord', ['>= 5.2', '< 6.1']
spec.add_development_dependency 'coveralls_reborn', '>= 0.18.0'
spec.add_development_dependency 'database_cleaner', '>= 1.2'
spec.add_development_dependency 'pg'
spec.add_development_dependency 'rake', '>= 12.3.3'
spec.add_development_dependency 'rspec', '~> 3'
spec.add_development_dependency 'simplecov'
spec.add_development_dependency 'timecop'

if RUBY_PLATFORM == 'java'
spec.add_development_dependency 'jdbc-sqlite3'
spec.add_development_dependency 'activerecord-jdbcsqlite3-adapter'
else
spec.add_development_dependency 'sqlite3', '~> 1.4'
end
end
5 changes: 0 additions & 5 deletions spec/db/database.yml

This file was deleted.

19 changes: 15 additions & 4 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,26 @@
ActiveRecord::Base.logger = Delayed::Worker.logger
ActiveRecord::Migration.verbose = false

db_adapter = ENV.fetch('ADAPTER', 'sqlite3')
config = YAML.load(File.read('spec/db/database.yml'))
ActiveRecord::Base.establish_connection(config[db_adapter])
require 'db/schema'
database_name = 'delayed_job_heartbeat_plugin_test'
database_host = ENV.fetch('PGHOST', 'localhost')
database_port = ENV.fetch('PGPORT', 5432)

RSpec.configure do |config|
config.order = 'random'

config.before(:suite) do
`dropdb --host #{database_host} --port #{database_port} --if-exists #{database_name} 2> /dev/null`
`createdb --host #{database_host} --port #{database_port} #{database_name}`
`psql --host #{database_host} --port #{database_port} --dbname #{database_name} --echo-all --file spec/setup_db.sql`

pg_version = `psql --host #{database_host} --port #{database_port} --dbname #{database_name} --tuples-only --command "select version()";`.strip
puts "Testing with Postgres version: #{pg_version}"
puts "Testing with ActiveRecord #{ActiveRecord::VERSION::STRING}"

database_url = "postgres://#{database_host}:#{database_port}/#{database_name}"
puts "Using database #{database_url}"
ActiveRecord::Base.establish_connection(database_url)
require 'db/schema'
DatabaseCleaner.clean_with(:truncation)
end

Expand Down

0 comments on commit ad1f6a6

Please sign in to comment.