Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing rails version to migration #6

Merged
merged 11 commits into from
Oct 14, 2020
Merged

Conversation

will89
Copy link
Contributor

@will89 will89 commented Oct 14, 2020

Rails migrations (>= 5.0) require the major and minor version in the generated migration file.

Maintenance:

Drop support for ruby < 2.5
Drop support for rails < 5.0
Fix coveralls
Switched test db from sqlite3 to postgresql because multithreading in spec/delayed/heartbeat/worker_heartbeat_spec.rb was causing a SQLite3::SQLException: no such table: delayed_workers: DELETE FROM "delayed_workers" WHERE "delayed_workers"."id" = ? (ActiveRecord::StatementInvalid). Apparently, sqlite3 is not multithreaded friendly.

prime: @jturkel

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 96.407% when pulling ab4dd5b on bug/missing-migration-version into d74b3ce on master.

@will89 will89 merged commit 23d7762 into master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants