Prep for an Addon Dummy site #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addons now have ember-disable-prototype-extensions included by default, this ensures add-ons are written in a way that works regardless of the consumers prototype extension preference. Caused issues creating a dummy(demo) app.
brandonhilkert
added a commit
that referenced
this pull request
Jun 27, 2015
Prep for an Addon Dummy site
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry to keep picking on your addon. 馃榾
I wanted to test out ember-cli-github-pages and decided to use your addon as a guinea pig.
Added
stickyas a bower dependencyRefactored the Ember server to work in an Ember Addon Environment (function prototypes aren't modified with .on, .property). Even gave me trouble with the Array of data.
Got the ember-cli-github-pages working, but more pull requests incoming...
See: http://jhr007.github.io/ember-cli-sticky/