Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #116 #117

Merged
merged 2 commits into from
Sep 28, 2018
Merged

Fix #116 #117

merged 2 commits into from
Sep 28, 2018

Conversation

dfreeman
Copy link
Member

Prior to this, we always synthesized a class attribute at the very end of an element's attributes, so

<div class="foo" local-class="bar" ...attributes>

Would become:

<div ...attributes class="foo {{local-class 'bar' from='xxxxx'}}">

But the collision behavior with splattributes is weird when the base values are specified after ...attributes, so we switch to putting the class at the beginning.

@dfreeman dfreeman merged commit 9ad580e into master Sep 28, 2018
@dfreeman dfreeman deleted the fix-splattributes branch September 28, 2018 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant