Introduce scopeBehaviour css-modules option #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're looking to use ember-css-modules for our large apps. We'll be migrating away from ember-component-css. In order to do that seamlessly, we need to turn off behavior for localizing every selector. We want to localize explicitly via
:local(.component) { ... }syntax. So I thought I'd propose this change here to this addon. Basically after this one could sayscopeBehaviour: 'global'in the config and achieve the behavior I'm talking about.This is inspired by original postcss-modules option, documented here: https://github.com/madyankin/postcss-modules/tree/v6.0.0#generating-scoped-names
See this issue for the context: madyankin/postcss-modules#22 (comment)
Seems like they had it since 2016 so I hope this change to this addon would be welcome as well. If this is approved, I can add documentation.
Related PR to the broccoli-css-modules: salsify/broccoli-css-modules#27