Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added typescript and configured the environment to properly lint typescript files.
This PR only includes the addition of one typescript file conversion to try and focus review on the environmental changes while still having proof that the tools work as expected.
Merging this first means we can have more contributors to the conversion process.
I started going down the path of trying to make the Ember Try scenarios pass but that should probably be tackled as a separate effort. The implications for our ecosystem are non-trivial.
I'm leaving the preliminary steps here for later:
Ember Try:
Ember Try is currently failing on canary with an error (truncated):
app needs ember-auto-import >= 2: ember-source
https://github.com/salsify/ember-exclaim/runs/3910286495
In order to resolve this we are going to need to do a major release:
https://github.com/ef4/ember-auto-import/blob/main/docs/upgrade-guide-2.0.md#mandatory-top-level-auto-import
This also means we need to bump Node to 12:
https://github.com/salsify/ember-exclaim/runs/3910346877
This also means adding Webpack@5 as a dev dependency.
https://github.com/salsify/ember-exclaim/runs/3910462256