Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript #34

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Add typescript #34

merged 2 commits into from
Oct 18, 2021

Conversation

katrynmc
Copy link
Contributor

@katrynmc katrynmc commented Oct 8, 2021

Added typescript and configured the environment to properly lint typescript files.

This PR only includes the addition of one typescript file conversion to try and focus review on the environmental changes while still having proof that the tools work as expected.

Merging this first means we can have more contributors to the conversion process.

I started going down the path of trying to make the Ember Try scenarios pass but that should probably be tackled as a separate effort. The implications for our ecosystem are non-trivial.

I'm leaving the preliminary steps here for later:
Ember Try:
Ember Try is currently failing on canary with an error (truncated): app needs ember-auto-import >= 2: ember-source
https://github.com/salsify/ember-exclaim/runs/3910286495

In order to resolve this we are going to need to do a major release:
https://github.com/ef4/ember-auto-import/blob/main/docs/upgrade-guide-2.0.md#mandatory-top-level-auto-import

This also means we need to bump Node to 12:
https://github.com/salsify/ember-exclaim/runs/3910346877

This also means adding Webpack@5 as a dev dependency.
https://github.com/salsify/ember-exclaim/runs/3910462256

@katrynmc katrynmc force-pushed the add-typescript branch 2 times, most recently from bf7b2ce to 6a9a4fe Compare October 15, 2021 21:42
@katrynmc katrynmc marked this pull request as ready for review October 15, 2021 21:45
Copy link

@maurolemos maurolemos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me. Thanks for bootstrapping this effort 💪

@jamescdavis
Copy link
Contributor

Good call on delaying the ember-auto-import 2.x upgrade. I have ember-auto-import 2.x working in enhanced-content-ui, but we need to tread carefully with upgrading addons to ember-auto-import 2.x because:

BREAKING: addons that use ember-auto-import 2.0 require that the app also has ember-auto-import 2.0.

https://github.com/ef4/ember-auto-import/blob/main/packages/ember-auto-import/CHANGELOG.md#200

@katrynmc
Copy link
Contributor Author

Yeah I should have been more explicit non-trivial kinda minimizes it too much 😅

@katrynmc katrynmc merged commit 67c9e71 into master Oct 18, 2021
@katrynmc katrynmc deleted the add-typescript branch October 18, 2021 14:28
@katrynmc katrynmc mentioned this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants