Optimize association eager loading for a single model #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ations for a single model
# Conflicts: # benchmark/main.rb
fgarces
approved these changes
Dec 10, 2018
benchmark/single_model_benchmark.rb
Outdated
| require_relative 'performance_helper' | ||
|
|
||
| ForkingBenchmark.ips do |x| | ||
| x.time = 5 |
There was a problem hiding this comment.
is there any reason for 5 and 2 or just because they sounded fine?
There was a problem hiding this comment.
They were copied from the benchmark that landed in #77. Looks like these are the defaults for benchmark-ips though so I'll remove them.
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| ### 3.0.3 | |||
| - Optimize association eager loadable checks by caching information on the association's reflection. | |||
| - Optimize association eager loading if we're only eager loading associations for a single model. | |||
There was a problem hiding this comment.
I assume you havent released the gem, otherwise this should go into 3.0.4.
There was a problem hiding this comment.
Yup. I haven't released 3.0.3 yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change optimizes automatic eager loading when there's only a single model in the auto include context by just doing regular Rails association loading. This bypasses a bunch of extra work that the Rails preloader does. In benchmarks this reduces object allocations by 5% but does not result in a statistically significant throughput change (even though it was faster by about 10% in all of the experiments I ran):
I added a new benchmark as part of this change so I factored out some commonality between the benchmarks and added a script for running all benchmarks.
@fgarces - you're prime