Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the connection state query #14

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Fix the connection state query #14

merged 1 commit into from
Oct 20, 2020

Conversation

fgarces
Copy link
Member

@fgarces fgarces commented Oct 20, 2020

I renamed the column but didnt change the group section. I added a test to run the queries in the DB instead of mocking the connection.

@stanleyyamane you are prime

stanleyyamane
stanleyyamane approved these changes Oct 20, 2020
View reviewed changes
Copy link

@stanleyyamane stanleyyamane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 Looks good

@coveralls
Copy link

coveralls commented Oct 20, 2020 •
edited

Pull Request Test Coverage Report for Build 112

  • 45 of 45 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 98.601%
Totals Coverage Status
Change from base Build 109: 0.06%
Covered Lines: 141
Relevant Lines: 143
💛 - Coveralls

@fgarces fgarces merged commit dcb8eae into master Oct 20, 2020
@fgarces fgarces deleted the feature/fix-query branch October 20, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanleyyamane stanleyyamane stanleyyamane approved these changes

Assignees

@stanleyyamane stanleyyamane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fgarces @coveralls @stanleyyamane